Skip to content

[CodeGen][NPM] Account inserted passes for -start/stop options #148111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/vikramRH/npm_pending/port_imp_def
Choose a base branch
from

Conversation

vikramRH
Copy link
Contributor

@vikramRH vikramRH commented Jul 11, 2025

same as #138830

This partly solves the issue #138831 for -enable-new-pm.

#137290 will not have this problem, but this needs to be added this till we migrate to the new pass builder structure.
Even with this, there is no way to -start-after an inserted pass right now.

Co-authored-by : Oke, Akshat <Akshat.Oke@amd.com>

Comment on lines +582 to +585
if (Name == TargetPassT::name()) {
if (runBeforeAdding(InsertedPassT::name()))
MFPM.addPass(std::forward<InsertedPassT>(Pass));
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Name == TargetPassT::name()) {
if (runBeforeAdding(InsertedPassT::name()))
MFPM.addPass(std::forward<InsertedPassT>(Pass));
}
if (Name == TargetPassT::name() && runBeforeAdding(InsertedPassT::name()))
MFPM.addPass(std::forward<InsertedPassT>(Pass));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants