-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[CodeGen][NPM] Account inserted passes for -start/stop options #148111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vikramRH
wants to merge
1
commit into
users/vikramRH/npm_pending/port_imp_def
Choose a base branch
from
users/vikramRH/npm_pending/insert_start_stop_opt
base: users/vikramRH/npm_pending/port_imp_def
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CodeGen][NPM] Account inserted passes for -start/stop options #148111
vikramRH
wants to merge
1
commit into
users/vikramRH/npm_pending/port_imp_def
from
users/vikramRH/npm_pending/insert_start_stop_opt
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 11, 2025
cdevadas
approved these changes
Jul 11, 2025
Comment on lines
+582
to
+585
if (Name == TargetPassT::name()) { | ||
if (runBeforeAdding(InsertedPassT::name())) | ||
MFPM.addPass(std::forward<InsertedPassT>(Pass)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (Name == TargetPassT::name()) { | |
if (runBeforeAdding(InsertedPassT::name())) | |
MFPM.addPass(std::forward<InsertedPassT>(Pass)); | |
} | |
if (Name == TargetPassT::name() && runBeforeAdding(InsertedPassT::name())) | |
MFPM.addPass(std::forward<InsertedPassT>(Pass)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #138830
This partly solves the issue #138831 for -enable-new-pm.
#137290 will not have this problem, but this needs to be added this till we migrate to the new pass builder structure.
Even with this, there is no way to -start-after an inserted pass right now.
Co-authored-by : Oke, Akshat <Akshat.Oke@amd.com>